Adam Litke has posted comments on this change. Change subject: tests: Add test_missing_tags for block storage ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/56171/2/tests/blocksdTests.py File tests/blocksdTests.py: Line 65 Line 66 Line 67 Line 68 Line 69 > Why not return fake lv instead of reading lvm output? This tests lvm module unrelated to this patch. These tests can all be converted to fake env infrastructure in a different patch. -- To view, visit https://gerrit.ovirt.org/56171 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb789cf146a4a9919e4dc864a0ae744e06510cec Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
