Ayal Baron has posted comments on this change.
Change subject: BZ#836161 - Pluralize lvm.changelv().
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File vdsm/storage/lvm.py
Line 744: # so we invalidate cache to reload these volumes on first occasion
Line 745: lvnames = tuple("%s/%s" % (vg, lv) for lv in lvs)
Line 746: cmd = ["lvchange"]
Line 747: cmd.extend(LVM_NOBACKUP)
Line 748: if not isinstance(attrs[0], str):
why negative logic?
Line 749: # (("--aa", "v1"), ("--ab", "v2"))
Line 750: for attr in attrs:
Line 751: cmd.extend(attr)
Line 752: else:
--
To view, visit http://gerrit.ovirt.org/8289
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I22c4ef83f23c0004a5a1e6a8a7e55d13b56c4f50
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
