Ayal Baron has posted comments on this change.

Change subject: Rename parent volume in blockSD.getAllVolumes.
......................................................................


Patch Set 2: (2 inline comments)

The patch is fine, but for bookkeeping need to explain why you're doing this in 
the commit message.

....................................................
Commit Message
Line 3: AuthorDate: 2012-10-16 17:28:06 +0200
Line 4: Commit:     Eduardo Warszawski <[email protected]>
Line 5: CommitDate: 2012-10-16 17:37:25 +0200
Line 6: 
Line 7: Rename parent volume in blockSD.getAllVolumes.
why?
Line 8: 
Line 9: Change-Id: I62f1385e4af90a923c5d97a71571bea8780aa339


Line 5: CommitDate: 2012-10-16 17:37:25 +0200
Line 6: 
Line 7: Rename parent volume in blockSD.getAllVolumes.
Line 8: 
Line 9: Change-Id: I62f1385e4af90a923c5d97a71571bea8780aa339
related to?


--
To view, visit http://gerrit.ovirt.org/8608
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I62f1385e4af90a923c5d97a71571bea8780aa339
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to