Mark Wu has posted comments on this change.
Change subject: Adding hooks support for NIC hotplug
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(2 inline comments)
....................................................
Commit Message
Line 8:
Line 9: Adding the ability to write hooks for events
Line 10: of NIC hotplug and hotunplug.
Line 11: Hooks are: before_nic_hotplug, after_nic_unplug
Line 12: and after_nic_hotplug_fail
why not after_nic_hotplug, before_nic_hotunplug and after_nic_hotunplug_fail ?
Am I missing some design discussions?
Line 13:
Line 14: Change-Id: I253104ee9831a881e2fb06f0a658631662611d77
....................................................
File vdsm/libvirtvm.py
Line 1428:
Line 1429: nicParams = params.get('nic', {})
Line 1430: nic = NetworkInterfaceDevice(self.conf, self.log,
**nicParams)
Line 1431: nicXml = nic.getXML().toprettyxml(encoding='utf-8')
Line 1432: nicXml = hooks.before_nic_hotplug(nicXml, self.conf)
the nicParams is not included in self.conf at this point, how about passing it
the to hook script by the of param 'params' of _runHooksDir . Then the hook
can have different behavior according to the configuration.
Line 1433: self.log.debug("Hotplug NIC xml: %s" % (nicXml))
Line 1434:
Line 1435: try:
Line 1436: self._dom.attachDevice(nicXml)
--
To view, visit http://gerrit.ovirt.org/7224
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I253104ee9831a881e2fb06f0a658631662611d77
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Itzik Brown <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Itzik Brown <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
