Nir Soffer has submitted this change and it was merged. Change subject: vm: Add error logging in diskReplicateFinish ......................................................................
vm: Add error logging in diskReplicateFinish On failures of diskReplicateFinish we had mostly no logs, making debugging much harder. Log error for each failure explaining the error, and include the source disk, drive name, and the libvirt job info. Change-Id: Ibcfe5a6e2f3dcd03ea07df523723e8134239fd59 Bug-Url: https://bugzilla.redhat.com/1325791 Signed-off-by: Nir Soffer <nsof...@redhat.com> Reviewed-on: https://gerrit.ovirt.org/55939 Reviewed-by: Francesco Romani <from...@redhat.com> Reviewed-by: Freddy Rolland <froll...@redhat.com> --- M vdsm/virt/vm.py 1 file changed, 14 insertions(+), 2 deletions(-) Approvals: Nir Soffer: Verified; Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve Francesco Romani: Looks good to me, approved Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/55939 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibcfe5a6e2f3dcd03ea07df523723e8134239fd59 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches