Igor Lvovsky has posted comments on this change.

Change subject: volume: save the correct size during creation
......................................................................


Patch Set 4: (1 inline comment)

....................................................
File vdsm/storage/volume.py
Line 484:                         "match the granularity on domain %s, updating 
the "
Line 485:                         "volume size from %s to %s", volUUID, sdUUID, 
size,
Line 486:                         apparentSize)
Line 487:                     size = apparentSize
Line 488: 
Is it possible to refactor it out to something like sizeRecalc() function ?
Line 489:             vars.task.pushRecovery(
Line 490:                 task.Recovery("Create volume metadata rollback", 
clsModule,
Line 491:                               clsName, "createVolumeMetadataRollback",
Line 492:                               map(str, metaId))


--
To view, visit http://gerrit.ovirt.org/8629
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I155b93e156fd80788b2f97bf69d8db5452ab64d3
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to