Dan Kenigsberg has posted comments on this change. Change subject: BZ#855924 fix VM config dictionary ......................................................................
Patch Set 2: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/vm.py Line 218: # "devices" doesn't cause errors Line 219: for drive in self._vm.conf['drives']: Line 220: if drive['device'] == item: Line 221: self._vm.conf[item] = drive['path'] Line 222: self._vm.conf['drives'].pop( are you trying to pop from a list while iterating over it? that's bad. Line 223: self._vm.conf['drives'].index(drive)) Line 224: Line 225: def run(self): Line 226: try: -- To view, visit http://gerrit.ovirt.org/8627 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33e957f8daac4266d9e19cc008cf830bd395fffe Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Gal Hammer <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Peter V. Saveliev <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
