Dan Kenigsberg has submitted this change and it was merged. Change subject: build: Remove pep8 and pyflakes requirement ......................................................................
build: Remove pep8 and pyflakes requirement We use to build-require both pep8 and pyflakes, which cause trouble when using older version. This leads to build failures, or to horrible code tyring to make old buggy pyflakes happy. Vdsm does not require pep8 or pyflakes for building packages; these are development tools that should be installed on a development machine or on CI environment, using the versions supported by current vdsm code. In the makefile, "make check" during make rpm was disabled on EL, because incompatible or missing pep8 and pyflakes versions; This hack was removed, so make rpm will do the same thing all platforms. In the makfile, we run pep8 or pyflakes checks only if these tools are installed. 4 copies of incompatible pep8 and pyflakes version were removed from the packages list. Finally, we install the correct version of these tools in the CI environment using pip. Change-Id: I6f0cdf21f18604c3fe81fa724aab0e613fb04289 Signed-off-by: Nir Soffer <nsof...@redhat.com> Reviewed-on: https://gerrit.ovirt.org/56152 Reviewed-by: Yaniv Bronhaim <ybron...@redhat.com> Tested-by: Yaniv Bronhaim <ybron...@redhat.com> Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg <dan...@redhat.com> --- M Makefile.am M automation/build-artifacts.sh M automation/check-merged.packages.el7 M automation/check-merged.packages.fc23 M automation/check-patch.packages.el7 M automation/check-patch.packages.fc23 M automation/check-patch.sh M vdsm.spec.in 8 files changed, 23 insertions(+), 33 deletions(-) Approvals: Yaniv Bronhaim: Verified; Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/56152 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f0cdf21f18604c3fe81fa724aab0e613fb04289 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
