Milan Zamazal has posted comments on this change. Change subject: virt: Don't set connected attribute in <graphics> if already set ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/56224/4//COMMIT_MSG Commit Message: Line 19: Line 20: In theory, it prevents changing the attribute value from Engine after Line 21: the VM has been started. But we don't support such a feature now and Line 22: we're probably not going to add it in a foreseeable future, so this Line 23: limitation shouldn't matter. > This smells like the wrong place to fix. If we want to support shared sessi Because we officially don't support this feature. Multiple SPICE connections may not be reliable and we don't want to support or advertise them. But if users want to experiment with them via Vdsm hooks on their own risks, we shouldn't block them. Line 24: Line 25: Change-Id: Ie7c49b26675f06a4914e97d1d85f2355ee6a083c Line 26: Bug-Url: https://bugzilla.redhat.com/1060573 -- To view, visit https://gerrit.ovirt.org/56224 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7c49b26675f06a4914e97d1d85f2355ee6a083c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
