Ondřej Svoboda has posted comments on this change. Change subject: ifcfg: consume bond slaves owned by NetworkManager ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/56364/3/lib/vdsm/network/configurators/ifcfg.py File lib/vdsm/network/configurators/ifcfg.py: PS3, Line 165: if slave.name in nicsToAdd: > +1 for this, but please add a more succinct comment I only changed the comment. Or did you also want the alternative if-else approach? I find it more understandable personally, even if it duplicates a little code. -- To view, visit https://gerrit.ovirt.org/56364 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77a600cd3bfddc0da48ae801bb121a8093254ae2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
