Nir Soffer has posted comments on this change. Change subject: storage: move outOfProcess module to vdsm storage lib ......................................................................
Patch Set 2: (8 comments) Looks fine after converting all the import to from vdsm ... https://gerrit.ovirt.org/#/c/56576/2/lib/vdsm/storage/outOfProcess.py File lib/vdsm/storage/outOfProcess.py: Line 25: import types Line 26: from warnings import warn Line 27: import weakref Line 28: Line 29: from __future__ import absolute_import This must be the first import in the file. Line 30: Line 31: from vdsm import constants Line 32: from vdsm.config import config Line 33: from vdsm.storage import exception as se https://gerrit.ovirt.org/#/c/56576/2/tests/outOfProcessTests.py File tests/outOfProcessTests.py: Line 18: # Refer to the README and COPYING files for full details of the license Line 19: # Line 20: Line 21: from testlib import VdsmTestCase as TestCaseBase Line 22: import vdsm.storage.outOfProcess as oop from vdsm.storage import outOfProcess as oop Line 23: from monkeypatch import MonkeyPatchScope Line 24: Line 25: import gc Line 26: import logging https://gerrit.ovirt.org/#/c/56576/2/vdsm/storage/fileSD.py File vdsm/storage/fileSD.py: Line 29: from vdsm.storage import exception as se Line 30: from vdsm.storage import fileUtils Line 31: from vdsm.storage import mount Line 32: from vdsm.storage.persistent import PersistentDict, DictValidator Line 33: import vdsm.storage.outOfProcess as oop from ... Line 34: Line 35: import sd Line 36: import sdm.volume_artifacts Line 37: import fileVolume https://gerrit.ovirt.org/#/c/56576/2/vdsm/storage/fileVolume.py File vdsm/storage/fileVolume.py: Line 27: from vdsm.commands import grepCmd Line 28: from vdsm.storage import exception as se Line 29: from vdsm.storage.constants import FILE_VOLUME_PERMISSIONS Line 30: from vdsm.storage.constants import LEASE_FILEEXT Line 31: import vdsm.storage.outOfProcess as oop from... Line 32: from vdsm.storage.threadLocal import vars Line 33: Line 34: from sdc import sdCache Line 35: import volume https://gerrit.ovirt.org/#/c/56576/2/vdsm/storage/hsm.py File vdsm/storage/hsm.py: Line 48: from vdsm.storage import fileUtils Line 49: from vdsm.storage import mount Line 50: from vdsm.storage.constants import STORAGE Line 51: from vdsm.storage.constants import SECTOR_SIZE Line 52: import vdsm.storage.outOfProcess as oop from Line 53: from vdsm.storage.threadLocal import vars Line 54: Line 55: import sp Line 56: from spbackends import MAX_POOL_DESCRIPTION_SIZE, MAX_DOMAINS https://gerrit.ovirt.org/#/c/56576/2/vdsm/storage/nfsSD.py File vdsm/storage/nfsSD.py: Line 22: Line 23: from vdsm.storage import exception as se Line 24: from vdsm.storage import fileUtils Line 25: from vdsm.storage import mount Line 26: import vdsm.storage.outOfProcess as oop from Line 27: Line 28: import sd Line 29: import fileSD Line 30: import misc https://gerrit.ovirt.org/#/c/56576/2/vdsm/storage/sd.py File vdsm/storage/sd.py: Line 26: import codecs Line 27: from contextlib import contextmanager Line 28: Line 29: from vdsm.storage import exception as se Line 30: import vdsm.storage.outOfProcess as oop from Line 31: from vdsm.storage.persistent import unicodeEncoder, unicodeDecoder Line 32: Line 33: import image Line 34: import misc https://gerrit.ovirt.org/#/c/56576/2/vdsm/storage/task.py File vdsm/storage/task.py: Line 52: from contextlib import contextmanager Line 53: from functools import wraps Line 54: Line 55: from vdsm.storage import exception as se Line 56: import vdsm.storage.outOfProcess as oop from Line 57: from vdsm.storage.threadLocal import vars Line 58: Line 59: import uuid Line 60: import misc -- To view, visit https://gerrit.ovirt.org/56576 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I390f8bc440c377b225a328aeb424233498522a5a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amit Aviram <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Idan Shaby <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
