Nir Soffer has submitted this change and it was merged. Change subject: Refactor metadata operations ......................................................................
Refactor metadata operations Volume metadata can be represented as a dictionary and as a string of delineated key value pairs. Extract this logic out of the Volume classes into a new VolumeMetadata class which can be unit tested. Once refactored, this code can be reused by new SDM code as well. Change-Id: I4fee56b30c13a3c1cede8489338ed60f4e1d5eab Signed-off-by: Adam Litke <ali...@redhat.com> Reviewed-on: https://gerrit.ovirt.org/52671 Continuous-Integration: Jenkins CI Reviewed-by: Freddy Rolland <froll...@redhat.com> Reviewed-by: Nir Soffer <nsof...@redhat.com> --- M tests/Makefile.am M tests/sdm_indirection_tests.py A tests/storage_volume_metadata_test.py M vdsm/storage/sdm/volume_artifacts.py M vdsm/storage/volume.py 5 files changed, 208 insertions(+), 57 deletions(-) Approvals: Adam Litke: Verified Nir Soffer: Looks good to me, approved Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/52671 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4fee56b30c13a3c1cede8489338ed60f4e1d5eab Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
