Nir Soffer has posted comments on this change. Change subject: tests: volume_artifacts: validate FileVolumeArtifacts metadata ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/56172/2/tests/storage_volume_artifacts_test.py File tests/storage_volume_artifacts_test.py: Line 267: md = volume.VolumeMetadata.from_lines(md_lines) Line 268: Line 269: # Test a few fields just to check that metadata was written Line 270: self.assertEqual(artifacts.sd_manifest.sdUUID, md.sd_id) Line 271: self.assertEqual(artifacts.img_id, md.img_id) > Because it would add unnecessary complication to the tests which would now OK Line 272: Line 273: def failure(*args): Line 274: raise ExpectedFailure() Line 275: -- To view, visit https://gerrit.ovirt.org/56172 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I366fd989b1387aa483a74e14dcfdc91b9f422060 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
