Nir Soffer has posted comments on this change.

Change subject: storage: move threadPool module to vdsm storage lib
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/56571/2/lib/vdsm/storage/threadPool.py
File lib/vdsm/storage/threadPool.py:

Line 5: # License: PSF License
Line 6: # http://wiki.python.org/moin/PythonSoftwareFoundationLicenseV2Easy
Line 7: #
Line 8: 
Line 9: from __future__ import absolute_import
> I think it makes the CI tests to fail:
Yes, we have stupid verification code that should be fixed or removed.
Line 10: from __future__ import print_function
Line 11: 
Line 12: import threading
Line 13: from time import sleep


-- 
To view, visit https://gerrit.ovirt.org/56571
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie5f4edd8eea38fdb6bdf3be5c7732fee0b56d58e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <[email protected]>
Gerrit-Reviewer: Amit Aviram <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Freddy Rolland <[email protected]>
Gerrit-Reviewer: Idan Shaby <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: gerrit-hooks <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to