Francesco Romani has posted comments on this change. Change subject: hostdev: add support for SCSI ......................................................................
Patch Set 7: Code-Review+1 (1 comment) please check the inline comment https://gerrit.ovirt.org/#/c/55024/7/lib/vdsm/hostdev.py File lib/vdsm/hostdev.py: PS7, Line 79: Read adapter info from scsi host address, and mutate the adress (removing : 'host' key) to conform to libvirt. : """ : adapter = 'scsi_host{}'.format(scsi_address['host']) : scsi_address['unit'] = scsi_address['lun'] : del scsi_address['lun'] : del scsi_address['host'] : : return {'name': adapter} same comment as ps5: why not just return a fresh dict with just the correct fields? -- To view, visit https://gerrit.ovirt.org/55024 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib049bc8669d3dc14a83c89c0d03f3410f242e1cd Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
