Milan Zamazal has posted comments on this change. Change subject: hostdev: expose generic scsi driver char device in device params ......................................................................
Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/55022/6/lib/vdsm/hostdev.py File lib/vdsm/hostdev.py: Line 183: except AttributeError: Line 184: # Is not scsi char device. Line 185: pass Line 186: else: Line 187: params['udev_path'] = udev_path Does it mean this is *scsi* char device here? Or don't we mind (if this is the case then it's not clear from the commit message)? Line 188: Line 189: iommu_group = caps.find('iommuGroup') Line 190: if iommu_group is not None: Line 191: params['iommu_group'] = iommu_group.attrib['number'] -- To view, visit https://gerrit.ovirt.org/55022 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I91e6793e946310b57e3004cbebc286cc6e00a724 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches