Edward Haas has posted comments on this change. Change subject: net: native ovs: store constants in __init__ ......................................................................
Patch Set 10: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/56451/10/lib/vdsm/network/ovs/switch.py File lib/vdsm/network/ovs/switch.py: Line 25: from vdsm.netconfpersistence import RunningConfig Line 26: from vdsm.netinfo.cache import CachingNetInfo Line 27: Line 28: from . import validator Line 29: from . import SWITCH_TYPE We do not need this change at the moment. I find in strange that we'll need such a thing when we are already in the OVS code domain. Line 30: Line 31: SWITCH_TYPE Line 32: Line 33: -- To view, visit https://gerrit.ovirt.org/56451 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09daa5d3a346bed2449de1765195ca4eb880c151 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
