Milan Zamazal has posted comments on this change.

Change subject: hostdev: use setup instead of detach in hotplug
......................................................................


Patch Set 3: Code-Review-1

This is confusing. Why do we call the method HostDevice.setup when its 
docstring speaks about detaching instead?

-- 
To view, visit https://gerrit.ovirt.org/56338
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I96853249e32c7b15c6a1c11b5a1ab385d7c4c827
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpoled...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to