Liron Aravot has posted comments on this change. Change subject: monitor: Convert valid to read-only property ......................................................................
Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/39088/3/tests/storageMonitorTests.py File tests/storageMonitorTests.py: Line 41: def test_deleting_attribute_raises(self): Line 42: for name in self.status.__slots__: Line 43: self.assertRaises(AssertionError, delattr, self.frozen, name) Line 44: Line 45: def test_valid(self): I don't see how this test is needed, the FrozenStatusTests is about making sure that the FrozenStatus is created properly. The frozen attribute will be checked with the rest of the attributes in test_copy_attributes Line 46: self.assertTrue(self.frozen.valid) Line 47: Line 48: Line 49: class StatusValidTests(VdsmTestCase): Line 49: class StatusValidTests(VdsmTestCase): Line 50: Line 51: def test_valid(self): Line 52: s = monitor.Status() Line 53: self.assertTrue(s.valid) lets add assertion that verifies that error is None Line 54: Line 55: def test_invalid(self): Line 56: s = monitor.Status() Line 57: s.error = Exception() -- To view, visit https://gerrit.ovirt.org/39088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff27081041bbaa1e319539df67abb31f38367e7d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
