Shahar Havivi has posted comments on this change. Change subject: kvm2ovirt: tool for copying images from libvirt ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/55797/5/helpers/kvm2ovirt File helpers/kvm2ovirt: Line 73: sys.stdout.flush() Line 74: Line 75: Line 76: def volume_progress(op, done): Line 77: while op.done < op.size: > op.size may be None, causing the progress thread to crash (see vdms log for you mean min() max() returns 99/100 immediately... Line 78: progress = op.done * 100 // op.size Line 79: write_progress(progress) Line 80: if done.wait(1): Line 81: break -- To view, visit https://gerrit.ovirt.org/55797 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d95c3bf4b2605e71f899171259d4721204eb8e2 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: Yaniv Kaul <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
