Irit Goihman has posted comments on this change. Change subject: Using pkgutil instead of redundant private funcs in configurator ......................................................................
Patch Set 10: (4 comments) https://gerrit.ovirt.org/#/c/53214/9/lib/vdsm/module_loader.py File lib/vdsm/module_loader.py: PS9, Line 32: i > We try to avoid this line breaker. Done https://gerrit.ovirt.org/#/c/53214/9/tests/Makefile.am File tests/Makefile.am: PS9, Line 111: . > It will be better to name tests with *_test , just to sync with py.test sta Done https://gerrit.ovirt.org/#/c/53214/9/tests/module_loader_tests.py File tests/module_loader_tests.py: PS9, Line 48: : : : > On liner fits here nicely: self.assertEquals(result, expected) Done https://gerrit.ovirt.org/#/c/53214/7/tests/module_utils_tests.py File tests/module_utils_tests.py: Line 28 Line 29 Line 30 Line 31 Line 32 > Just softly reminding everyone that I dislike permutations. :) :) -- To view, visit https://gerrit.ovirt.org/53214 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec710e795aeaf5b611f6dbe4f8ea535c8be5fa14 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
