Douglas Schilling Landgraf has posted comments on this change. Change subject: Validating number of required args in spmStart() ......................................................................
Patch Set 1: (1 inline comment) .................................................... File vdsm_cli/vdsClient.py Line 713: return res['status']['code'], res['status']['message'] Line 714: return 0, '' Line 715: Line 716: def spmStart(self, args): Line 717: validateArgTypes(args, [str, int, int, int, str, int, int], 5) I would use validateArgTypes(args, ...., requiredArgsNumber=5) should be enough (IMO).. but that's a style. Line 718: status = self.s.spmStart(*args) Line 719: if status['status']['code']: Line 720: return status['status']['code'], status['status']['message'] Line 721: return 0, status['uuid'] -- To view, visit http://gerrit.ovirt.org/8731 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab0ddbd4b3f77fc2011e7b554a4800298a9cf39f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
