Edward Haas has posted comments on this change.

Change subject: macspoof hook: README: help adding the custom property
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/56015/2/vdsm_hooks/macspoof/README
File vdsm_hooks/macspoof/README:

PS2, Line 12: Custom property for a specific vNIC in a VM:
            :     sudo engine-config -g CustomDeviceProperties
            : shows the current value of CustomDeviceProperties. It's content 
may look like
            :     
{type=interface;prop={property_name1=regexp1;property_name2=regexp2}}
            : add "ifacemacspoof=^(true|false)$" to the semicolon-separated 
list of
            : properties and set
            :     sudo engine-config -s 
"CustomDeviceProperties={type=interface;prop={somthing_you_had_before=regexp;ifacemacspoof=^(true|false)$}}"
How about this?

Custom property for a specific vNIC in a VM:
    Check current value of CustomDeviceProperties:
        sudo engine-config -g CustomDeviceProperties
    It's content may look like:
        {type=interface;prop={property_name1=regexp1;property_name2=regexp2}}
    Update CustomDeviceProperties and append "ifacemacspoof=^(true|false)$" to 
the existing value:
        sudo engine-config -s 
"CustomDeviceProperties={type=interface;prop={property_name1=regexp1;property_name2=regexp2;ifacemacspoof=^(true|false)$}}"


-- 
To view, visit https://gerrit.ovirt.org/56015
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7edb61612d5af913ec34d6077a0fa49fcc6ce63
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Edward Haas <edwa...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmire...@redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com>
Gerrit-Reviewer: Petr Horáček <phora...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to