Edward Haas has posted comments on this change. Change subject: net: add virtual port to libvirt network def ......................................................................
Patch Set 3: Code-Review-1 (3 comments) https://gerrit.ovirt.org/#/c/56828/3/lib/vdsm/network/configurators/libvirt.py File lib/vdsm/network/configurators/libvirt.py: PS3, Line 52: [<vlan><tag id='10'/></vlan>] I don't think it belongs to this patch. https://gerrit.ovirt.org/#/c/56828/3/tests/network/conf_test.py File tests/network/conf_test.py: PS3, Line 160: testCreateNetXmlVirtualport Please do not use Camel Case for new methods/funcs PS3, Line 161: virtualport = "openvswitch" I think you can loose this variable, it will be readable without it. -- To view, visit https://gerrit.ovirt.org/56828 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d081cb51d9f01eccbe28ced62e8bed07ac12396 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
