Edward Haas has posted comments on this change.

Change subject: configure: add support for nosetests/python 3.5
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/56083/3/configure.ac
File configure.ac:

Line 289:   fi
Line 290: 
Line 291:   AC_PATH_PROG([PYTHON3_NOSE], [nosetests-3.4])
Line 292:   if test "x$PYTHON3_NOSE" = "x"; then
Line 293:     AC_PATH_PROG([PYTHON3_NOSE], [nosetests-3.5])
> yes, and to do so I'll need to refresh my autoconf knowledge
I think you actually need https://gerrit.ovirt.org/#/c/56533
to work, that should solve these problems.

Unfortunately, there is a problem with that patch, but fixing it will make this 
patch unneeded.
Line 294:   fi
Line 295:   if test "x$PYTHON3_NOSE" = "x"; then
Line 296:     AC_MSG_ERROR([python3-nose not found])
Line 297:   fi


-- 
To view, visit https://gerrit.ovirt.org/56083
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1d5f0a8545ff0d3f3071a58f327a61892a57a71a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Edward Haas <edwa...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to