Edward Haas has posted comments on this change. Change subject: net: Move netconfpersistence under vdsm.network ......................................................................
Patch Set 2: (7 comments) https://gerrit.ovirt.org/#/c/56677/2/lib/vdsm/netinfo/cache.py File lib/vdsm/netinfo/cache.py: Line 25: import errno Line 26: import six Line 27: Line 28: from ..ipwrapper import getLinks Line 29: from vdsm.network.netconfpersistence import RunningConfig > seems odd here. please place on top of the in-package imports. Done Line 30: from ..netlink import link as nl_link Line 31: Line 32: from vdsm import netinfo Line 33: from .addresses import getIpAddrs, getIpInfo, is_ipv6_local_auto https://gerrit.ovirt.org/#/c/56677/2/lib/vdsm/network/api.py File lib/vdsm/network/api.py: Line 31: from vdsm.config import config Line 32: from vdsm import commands Line 33: from vdsm import constants Line 34: from vdsm import hooks Line 35: from . import netconfpersistence > now belongs to the next stanza Done Line 36: from vdsm import udevadm Line 37: from vdsm import ipwrapper Line 38: Line 39: from . canonicalize import canonicalize_networks, canonicalize_bondings https://gerrit.ovirt.org/#/c/56677/2/lib/vdsm/network/configurators/__init__.py File lib/vdsm/network/configurators/__init__.py: Line 21: import logging Line 22: from six.moves import configparser Line 23: Line 24: from vdsm.config import config Line 25: from vdsm.network.netconfpersistence import RunningConfig > alphabetic order places this under vdsm.netlink Done Line 26: from vdsm import ipwrapper Line 27: from vdsm.netinfo import mtus Line 28: from vdsm.netlink import monitor Line 29: https://gerrit.ovirt.org/#/c/56677/2/lib/vdsm/network/configurators/ifcfg.py File lib/vdsm/network/configurators/ifcfg.py: Line 45: NET_PATH) Line 46: from vdsm.netinfo.cache import ifaceUsed Line 47: from vdsm import sysctl Line 48: from vdsm import utils Line 49: from vdsm.network.netconfpersistence import RunningConfig, PersistentConfig > alphabetize Done Line 50: from vdsm.netlink import monitor Line 51: Line 52: if utils.isOvirtNode(): Line 53: from ovirt.node.utils import fs as node_fs https://gerrit.ovirt.org/#/c/56677/2/lib/vdsm/network/legacy_switch.py File lib/vdsm/network/legacy_switch.py: Line 27: Line 28: from vdsm.config import config Line 29: from vdsm import ipwrapper Line 30: from vdsm import kernelconfig Line 31: from . import netconfpersistence > next stanza Done Line 32: from vdsm.netinfo import NET_PATH Line 33: from vdsm.netinfo import addresses Line 34: from vdsm.netinfo import bridges Line 35: from vdsm.netinfo import mtus https://gerrit.ovirt.org/#/c/56677/2/lib/vdsm/tool/unified_persistence.py File lib/vdsm/tool/unified_persistence.py: Line 21: import logging Line 22: Line 23: from .. import utils Line 24: from ..config import config Line 25: from vdsm.network.netconfpersistence import RunningConfig > place above Done Line 26: from ..netinfo.cache import CachingNetInfo Line 27: from ..netinfo import misc, routes Line 28: from . import expose Line 29: from .upgrade import apply_upgrade https://gerrit.ovirt.org/#/c/56677/2/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 33: from vdsm import kernelconfig Line 34: from vdsm.ipwrapper import (routeExists, ruleExists, addrFlush, LinkType, Line 35: getLinks, routeShowTable, linkDel, linkSet, Line 36: addrAdd) Line 37: from vdsm.network.netconfpersistence import RunningConfig > place lower Done Line 38: from vdsm.netinfo.bonding import BONDING_SLAVES, BONDING_MASTERS Line 39: from vdsm.netinfo.bridges import bridges Line 40: from vdsm.netinfo.misc import NET_CONF_PREF Line 41: from vdsm.netinfo.mtus import DEFAULT_MTU -- To view, visit https://gerrit.ovirt.org/56677 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5325153a6462014d4b5e8300633d25757258d3c0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
