Petr Horáček has posted comments on this change. Change subject: net: Move netinfo under vdsm.network ......................................................................
Patch Set 2: (1 comment) Just one question. Some imports sorting and regrouping is needed, but let's ignore it for now, it would make it insane to review this. https://gerrit.ovirt.org/#/c/56713/2/configure.ac File configure.ac: Line 220: AC_SUBST([vdsmtsdir], ['${sysconfdir}/pki/vdsm']) Line 221: AC_SUBST([vdsmrepo], ['/rhev/data-center']) Line 222: AC_SUBST([vdsmpylibdir], ['${pythondir}/vdsm']) Line 223: AC_SUBST([vdsminfradir], ['${vdsmpylibdir}/infra']) Line 224: AC_SUBST([vdsmnetinfodir], ['${vdsmpylibdir}/network/netinfo']) should we still use AC_SUBST when netinfo is a part of network ? Line 225: AC_SUBST([vdsmtooldir], ['${vdsmpylibdir}/tool']) Line 226: AC_SUBST([configuratorsdir], ['${vdsmtooldir}/configurators']) Line 227: AC_SUBST([vdsmtestsdir], ['${datarootdir}/vdsm/tests']) Line 228: -- To view, visit https://gerrit.ovirt.org/56713 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia02e5f79e093067789659e414b595aa4e3d5a62e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
