Piotr Kliczewski has posted comments on this change. Change subject: rpc: Add test for 'int' parameters in Bridge ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/56884/1/tests/bridgeTests.py File tests/bridgeTests.py: Line 155: Line 156: self.assertEquals(e.exception.code, 100) Line 157: Line 158: @MonkeyPatch(DynamicBridge, '_get_api_instance', _get_api_instance) Line 159: def testMethodWithIntParam(self): > key thing here is that the call to dispatch doesn't throw the 'int' is not Please check fenceNode you could check (value/type) it in similar way and here you could assert return value. Line 160: bridge = DynamicBridge() Line 161: Line 162: params = {"vmID": "773adfc7-10d4-4e60-b700-3272ee1871f9", Line 163: "params": {"vmID": "773adfc7-10d4-4e60-b700-3272ee1871f9"}, -- To view, visit https://gerrit.ovirt.org/56884 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie8a2672c53411bed1ac711fffccb543bcfb16024 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
