Nir Soffer has posted comments on this change. Change subject: storage: Add basic BlockVolumeArtifacts ......................................................................
Patch Set 19: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/55987/19/tests/storage_volume_artifacts_test.py File tests/storage_volume_artifacts_test.py: Line 377: slot_before = self.get_next_free_slot(env) Line 378: artifacts = env.sd_manifest.get_volume_artifacts( Line 379: self.img_id, self.vol_id) Line 380: with MonkeyPatchScope([ Line 381: [blockVolume.BlockVolumeManifest, '_putMetadata', failure] Now changing BlockVolumeManifest private method will break unrelated tests :-) Why not mock the public method used by BlockVolumeArtifacts? Line 382: ]): Line 383: self.assertRaises(ExpectedFailure, artifacts.create, Line 384: *BASE_RAW_PARAMS) Line 385: self.validate_invisibility(env, artifacts, is_garbage=True) -- To view, visit https://gerrit.ovirt.org/55987 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4120c557fc89d82cc6bc854a9fdc8935e53bc93d Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
