Milan Zamazal has posted comments on this change. Change subject: virt: Don't fail when existingConnAction is unset for a SPICE device ......................................................................
Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/56836/3/lib/api/vdsmapi-schema.json File lib/api/vdsmapi-schema.json: Line 7402: # @password: The desired connection password Line 7403: # Line 7404: # @ttl: The number of seconds before the password expires Line 7405: # Line 7406: # @existingConnAction: #optional Indicate what to do with any existing connections > please add a line like Done Line 7407: # (made optional in version 4.18.0) Line 7408: # Line 7409: # @params: Arbitrary key:val pairs that will be passed to hooks Line 7410: # https://gerrit.ovirt.org/#/c/56836/3/tests/vmOperationsTests.py File tests/vmOperationsTests.py: PS3, Line 146: graphics_params = dict(_GRAPHICS_DEVICE_PARAMS) : del graphics_params['existingConnAction'] > silly nit: I think I couldn't decide which version is better, so you resolved it. :-) Done. -- To view, visit https://gerrit.ovirt.org/56836 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2fde83ceb994eaafd2aa956d1fa82ce6cb16094c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
