Piotr Kliczewski has posted comments on this change. Change subject: stomp: make sure to handle eagain ......................................................................
Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/56997/1/lib/yajsonrpc/betterAsyncore.py File lib/yajsonrpc/betterAsyncore.py: Line 94: return '' Line 95: else: Line 96: return data Line 97: except socket.error as why: Line 98: # winsock sometimes raises ENOTCONN > you can update the doc above and say when EAGAIN is expected in few words.. Done Line 99: if why.args[0] in (EWOULDBLOCK, EAGAIN): Line 100: return None Line 101: elif why.args[0] in asyncore._DISCONNECTED: Line 102: self.handle_close() Line 95: else: Line 96: return data Line 97: except socket.error as why: Line 98: # winsock sometimes raises ENOTCONN Line 99: if why.args[0] in (EWOULDBLOCK, EAGAIN): > EWOULDBLOCK and EAGAIN are have the same value: Done Line 100: return None Line 101: elif why.args[0] in asyncore._DISCONNECTED: Line 102: self.handle_close() Line 103: return '' -- To view, visit https://gerrit.ovirt.org/56997 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7fcd96522f007dd7159c555080821c3e3f8abf1a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
