Francesco Romani has posted comments on this change. Change subject: Adding reportStats ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/56880/1/lib/vdsm/host.py File lib/vdsm/host.py: PS1, Line 454: reportStats I think the simplest/cleanest way is to add a new periodic.Operation, which will read from sampling.host_stats. In case you need to send the very same information that getStats() report, you may add a queue, like * Host.getStats() does its job exactly like today, writes the data ALSO to the new queue, before to return it * a new periodic operation reads and consumes the data from the queue, then reports it to statsd. If there is no data, it does nothing. what do you think about this? -- To view, visit https://gerrit.ovirt.org/56880 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23c1141f097f740441d085f99e0bf76eb7f718c9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yaniv Kaul <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
