Irit Goihman has posted comments on this change. Change subject: Using pkgutil instead of redundant private funcs in configurator ......................................................................
Patch Set 15: (5 comments) https://gerrit.ovirt.org/#/c/53214/15/lib/vdsm/tool/configurator.py File lib/vdsm/tool/configurator.py: PS15, Line 45: iterkeys > This is not compatible with python3. Done Line 42: from vdsm import module_loader Line 43: Line 44: _CONFIGURATORS = module_loader.load_modules(configurators) Line 45: for module_name in _CONFIGURATORS.iterkeys(): Line 46: print(module_name) > rmove print Done Line 47: if not hasattr(_CONFIGURATORS[module_name], 'name'): Line 48: setattr(_CONFIGURATORS[module_name], 'name', module_name) Line 49: Line 50: Line 44: _CONFIGURATORS = module_loader.load_modules(configurators) Line 45: for module_name in _CONFIGURATORS.iterkeys(): Line 46: print(module_name) Line 47: if not hasattr(_CONFIGURATORS[module_name], 'name'): Line 48: setattr(_CONFIGURATORS[module_name], 'name', module_name) > do it in a function - init_configurators which you call globaly Done Line 49: Line 50: Line 51: # Line 52: # Configurators Interface: https://gerrit.ovirt.org/#/c/53214/15/tests/module_loader_test.py File tests/module_loader_test.py: PS15, Line 41: sys.path.append(os.path.dirname(path)) > Is this for supporting relative imports? no, it adds the temporary path to modules search path. It's only related to the test. https://gerrit.ovirt.org/#/c/53214/15/vdsm.spec.in File vdsm.spec.in: Line 1120: %{python_sitelib}/%{vdsm_name}/kernelconfig.py* Line 1121: %{python_sitelib}/%{vdsm_name}/libvirtconnection.py* Line 1122: %{python_sitelib}/%{vdsm_name}/logUtils.py* Line 1123: %{python_sitelib}/%{vdsm_name}/m2cutils.py* Line 1124: %{python_sitelib}/%{vdsm_name}/machinetype.py* > here Done Line 1125: %{python_sitelib}/%{vdsm_name}/momIF.py* Line 1126: %{python_sitelib}/%{vdsm_name}/netinfo/__init__.py* Line 1127: %{python_sitelib}/%{vdsm_name}/netinfo/addresses.py* Line 1128: %{python_sitelib}/%{vdsm_name}/netinfo/bonding.py* -- To view, visit https://gerrit.ovirt.org/53214 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec710e795aeaf5b611f6dbe4f8ea535c8be5fa14 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
