Irit Goihman has posted comments on this change. Change subject: Move host stats dict creation from API.py to host module ......................................................................
Patch Set 6: (2 comments) https://gerrit.ovirt.org/#/c/56874/6/lib/vdsm/host.py File lib/vdsm/host.py: PS6, Line 106: '%02d-%02d-%02dT%02d:%02d:%02d GMT' % ( : tm_year, tm_mon, tm_day, tm_hour, tm_min, tm_sec) you can use string format instead PS6, Line 122: 1024 use const instead of actual number -- To view, visit https://gerrit.ovirt.org/56874 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I626a673c429d486ac78b309c2f31cb58af8852b2 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
