Edward Haas has posted comments on this change. Change subject: net: OVS Info ......................................................................
Patch Set 21: Code-Review+1 (2 comments) Note the small nit. https://gerrit.ovirt.org/#/c/56901/17/lib/vdsm/network/ovs/info.py File lib/vdsm/network/ovs/info.py: PS17, Line 62: > Done. However, dict is mutable, so I guess user still can write to its cont We could return a copy and be protected, but that we can consider later on.. https://gerrit.ovirt.org/#/c/56901/21/tests/network/ovs_info_test.py File tests/network/ovs_info_test.py: PS21, Line 149: s nit: The plural version is deprecated. -- To view, visit https://gerrit.ovirt.org/56901 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib43bee9a13cfabc3007064b2121f0ce8b0a563bb Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches