Nir Soffer has posted comments on this change. Change subject: storage: add support for blkdiscard command ......................................................................
Patch Set 6: (2 comments) https://gerrit.ovirt.org/#/c/35629/6/lib/vdsm/storage/blkdiscard.py File lib/vdsm/storage/blkdiscard.py: Line 43: def run_blkdiscard(device): Line 44: cmd = [_blkdiscard.cmd] Line 45: cmd.append(device) Line 46: Line 47: rc, out, err = commands.execCmd(cmd, deathSignal=signal.SIGKILL) > Since I'm hoping to see this in 4.0.x, not sure we can do that right now. I Right, we want this change *now*, we don't have time for additional work. Line 48: Line 49: if rc != 0: https://gerrit.ovirt.org/#/c/35629/6/tests/storage_blkdiscard_test.py File tests/storage_blkdiscard_test.py: Line 25: Line 26: BLKDISCARD = blkdiscard._blkdiscard.cmd Line 27: Line 28: Line 29: class FakeCmd(object): > This class looks like a general purpose utility that should appear in testl I agree, good idea for later patch. Line 30: Line 31: def __init__(self, name, *calls): Line 32: self.patch = monkeypatch.Patch([(commands, name, self)]) Line 33: self.calls = list(calls) -- To view, visit https://gerrit.ovirt.org/35629 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ea7dd19fadc600b8fe78fb436ae430d35f52165 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Idan Shaby <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Yaniv Kaul <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
