Liron Aravot has posted comments on this change. Change subject: sp: allow executing upgradePool even if there is a pending update ......................................................................
Patch Set 2: (3 comments) https://gerrit.ovirt.org/#/c/57188/2/vdsm/storage/sp.py File vdsm/storage/sp.py: Line 174 Line 175 Line 176 Line 177 Line 178 > This removes the upgrade_domain_uuid lock, right? indeed Line 202 Line 203 Line 204 Line 205 Line 206 > This changes pool, se we need exclusive lock on the pool for this operation i agree that it should be inspected, but this is irrelevant for this change - today the lock is taken for the domain only, so the list isn't updated under pool lock. Line 203 Line 204 Line 205 Line 206 Line 207 > This also changes the pool state, needs an exclusive lock on the pool. i agree that it should be inspected, but this is irrelevant for this change - today the lock is taken for the domain only, so the this method doesn't run under pool lock. -- To view, visit https://gerrit.ovirt.org/57188 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e14a3aa33bfab4751ab5d1e3becbeda892da4c3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
