Zhou Zheng Sheng has posted comments on this change.
Change subject: pep8: drop redundant trailing backslash
......................................................................
Patch Set 2: Verified; Looks good to me, but someone else must approve
(9 inline comments)
Build success. pydiff verified.
Minor problems in the original text.
....................................................
File tests/persistentDictTests.py
Line 68
Line 69
Line 70
Line 71
Line 72
The original text is missing space after the word 'people' and 'opposed',
should be
"Take the Kama Sutra. How many people "
"died from the Kama Sutra, as opposed "
....................................................
File vdsm/API.py
Line 176: self.log.error('Missing required parameter %s' %
(param))
Line 177: return {'status': {'code': errCode['MissParam']
Line 178:
['status']['code'],
Line 179: 'message': 'Missing required' +
Line 180: 'parameter %s' % (param)}}
The original text is missing space after the word 'required', and '+' is not
useful here. Should be
'message': 'Missing required '
'parameter %s' % (param)
Line 181: try:
Line 182: storage.misc.validateUUID(vmParams['vmId'])
Line 183: except:
Line 184: return {'status': {'code': errCode['MissParam']
Line 359: except ValueError:
Line 360: self.log.error('Missing one of required parameters: vmId,
nic')
Line 361: return {'status': {'code':
errCode['MissParam']['status']['code'],
Line 362: 'message': 'Missing one of required' +
Line 363: 'parameters: vmId, nic'}}
Same as line 180.
Line 364: try:
Line 365: curVm = self._cif.vmContainer[self._UUID]
Line 366: except KeyError:
Line 367: self.log.warning("vm %s doesn't exist", self._UUID)
Line 375: except ValueError:
Line 376: self.log.error('Missing one of required parameters: vmId,
nic')
Line 377: return {'status': {'code':
errCode['MissParam']['status']['code'],
Line 378: 'message': 'Missing one of required' +
Line 379: 'parameters: vmId, nic'}}
Same as line 180.
Line 380: try:
Line 381: curVm = self._cif.vmContainer[self._UUID]
Line 382: except KeyError:
Line 383: self.log.warning("vm %s doesn't exist", self._UUID)
Line 391: except ValueError:
Line 392: self.log.error('Missing one of required parameters: vmId,
drive')
Line 393: return {'status': {'code':
errCode['MissParam']['status']['code'],
Line 394: 'message': 'Missing one of required' +
Line 395: 'parameters: vmId, drive'}}
Same as line 180.
Line 396: try:
Line 397: curVm = self._cif.vmContainer[self._UUID]
Line 398: except KeyError:
Line 399: self.log.warning("vm %s doesn't exist", self._UUID)
Line 407: except ValueError:
Line 408: self.log.error('Missing one of required parameters: vmId,
drive')
Line 409: return {'status': {'code':
errCode['MissParam']['status']['code'],
Line 410: 'message': 'Missing one of required' +
Line 411: 'parameters: vmId, drive'}}
Same as line 180.
Line 412: try:
Line 413: curVm = self._cif.vmContainer[self._UUID]
Line 414: except KeyError:
Line 415: self.log.warning("vm %s doesn't exist", self._UUID)
Line 1120:
Line 1121: Doesn't survive a restart
Line 1122: """
Line 1123: logging.getLogger('clientIF.setLogLevel').info('Setting
loglevel' +
Line 1124: 'to %s' %
level)
Same as line 180.
Line 1125: handlers = logging.getLogger().handlers
Line 1126: [fileHandler] = [h for h in handlers if
Line 1127: isinstance(h, logging.FileHandler)]
Line 1128: fileHandler.setLevel(int(level))
Line 1205:
Line 1206: if vlan or bond or nics:
Line 1207: # Backwards compatibility
Line 1208: self.log.warn('Specifying vlan,' +
Line 1209: 'bond or nics to delNetwork is
deprecated')
Same as line 180.
Line 1210: _netinfo = netinfo.NetInfo()
Line 1211: try:
Line 1212: if bond:
Line 1213: configNetwork.validateBondingName(bond)
Line 1215: configNetwork.validateVlanId(vlan)
Line 1216: if nics and bond and set(nics) != \
Line 1217: set(_netinfo.bondings[bond]["slaves"]):
Line 1218: self.log.error('delNetwork: not all nics
specified' +
Line 1219: 'are enslaved (%s != %s)' %
Same as line 180.
Line 1220: (nics,
Line 1221:
_netinfo.bondings[bond]["slaves"]))
Line 1222: raise configNetwork.ConfigNetworkError(
Line 1223: configNetwork.ne.ERR_BAD_NIC,
--
To view, visit http://gerrit.ovirt.org/8752
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id702c194ecff6e231539fd88fa20188f31326948
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
