Pavel Zhukov has posted comments on this change. Change subject: hooks: Add fcoe hook ......................................................................
Patch Set 20: Verified-1 (1 comment) https://gerrit.ovirt.org/#/c/55029/20/vdsm_hooks/fcoe/fcoe_before_network_setup.py File vdsm_hooks/fcoe/fcoe_before_network_setup.py: Line 50: utils.rmFile(filename) Line 51: utils.unpersist(filename) Line 52: Line 53: Line 54: def main(): > There is too may variable here with unclear names, and too much logic. For existed networks it's ok but that about removed and changed_ dicts? I don't think three iterations is better than one Line 55: """ Line 56: Create lists of running networks Line 57: and networks to be (un)configured as FCoE or removed. Line 58: """ -- To view, visit https://gerrit.ovirt.org/55029 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad2faed7205ca08801132df072b469dbe781318c Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Pavel Zhukov <pzhu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabi...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Pavel Zhukov <pzhu...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: Yaniv Kaul <yk...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
