Adam Litke has posted comments on this change. Change subject: block: simplify zeroImgVolumes using threads ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/35630/3/vdsm/storage/blockSD.py File vdsm/storage/blockSD.py: Line 227: deleteVolumes(sdUUID, volUUID) Line 228: log.debug('zeroing of volume %s on domain %s for task %s ' Line 229: 'completed successfully', volUUID, sdUUID, taskid) Line 230: Line 231: misc.tmap(zeroVolume, volUUIDs) > We can use itmap to get one uuid of zeroed and discarded volume and delete We need some reasonable limits on concurrency here. itmap is a step in the right direction but deleting multiple images at the same time could still exhaust all the available threads (not to mention storage bandwidth). Ultimately, I think we need a separate thread pool for IO intensive operations such as this. Then, we can schedule as many of these as we want and the system will not become overloaded. Line 232: Line 233: Line 234: class VGTagMetadataRW(object): Line 235: log = logging.getLogger("Storage.Metadata.VGTagMetadataRW") -- To view, visit https://gerrit.ovirt.org/35630 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I665d863085842de8ff93c9aacf7c26277dfb031d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yaniv Kaul <yk...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
