Milan Zamazal has posted comments on this change. Change subject: migration: Enable lazy setting of incoming/outgoing limits ......................................................................
Patch Set 30: Code-Review-1 (2 comments) Just a documentation issue, please fix it if possible to avoid confusion. https://gerrit.ovirt.org/#/c/53305/25/vdsm/API.py File vdsm/API.py: Line 573: except KeyError: Line 574: return errCode['noVM'] Line 575: return v.migrateCancel() Line 576: Line 577: def migrationCreate(self, params, incomingLimit=None): It's uint according to the schema. Line 578: """ Line 579: Start a migration-destination VM. Line 580: Line 581: :param params: parameters of new VM, to be passed to https://gerrit.ovirt.org/#/c/53305/30/vdsm/API.py File vdsm/API.py: Line 586: :type incomingLimit: int Line 587: """ Line 588: self.log.debug('Migration create') Line 589: Line 590: if incomingLimit: > Should be a illegal value, so it should be OK that the setting is skipped. OK, then it should be documented in the schema and the docstrings that incomingLimit (and outgoingLimit?) must be positive numbers. Line 591: self.log.debug('Setting incoming migration limit to %s', Line 592: incomingLimit) Line 593: migration.incomingMigrations.bound = incomingLimit Line 594: -- To view, visit https://gerrit.ovirt.org/53305 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79ab97f15788e4024c94d051e4aade713d760acf Gerrit-PatchSet: 30 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
