Petr Horáček has posted comments on this change. Change subject: net: OVS netinfo ......................................................................
Patch Set 31: Verified+1 (5 comments) Passed ovs_info_test.py https://gerrit.ovirt.org/#/c/56972/30/lib/vdsm/network/ovs/info.py File lib/vdsm/network/ovs/info.py: PS30, Line 112: 'fak > Nice Thanks! PS30, Line 117: > What about a generator expressions? Done PS30, Line 122: > Same here, a generator expression may fit. Done PS30, Line 157: ound_bond_attrs['slaves' > I meant something else, which fits bridge_attrs as well: Done for bridge_attrs - stp. For vlan I see no reason, we have to resolve it per each network and both northbound and ports are needed here. Line 165: 'ports': _get_net_ports(bridge, northbound, southbound, ports), Line 166: 'stp': stp, Line 167: 'switch': 'ovs' Line 168: } Line 169: network_info.update(_get_iface_info(northbound, addresses, routes)) > Ah.. sorry for this: Done Line 170: return network_info Line 171: Line 172: Line 173: def _get_net_ports(bridge, northbound, southbound, ports): -- To view, visit https://gerrit.ovirt.org/56972 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5dd351faf108fd04afa78208d9c34451a856d4a Gerrit-PatchSet: 31 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
