Nir Soffer has posted comments on this change. Change subject: Makefile: use tox to run make pep8 and pyflakes ......................................................................
Patch Set 14: (4 comments) https://gerrit.ovirt.org/#/c/49952/14/Makefile.am File Makefile.am: Line 107 Line 108 Line 109 Line 110 Line 111 We need this warning when tox is not available. Line 120 Line 121 Line 122 Line 123 Line 124 We need this warning when tox is not available. Line 96: done; Line 97: Line 98: .PHONY: pyflakes Line 99: pyflakes: Line 100: tox -- 'pyflakes' > Quotes unneeded We must add a check for tox in configure.ac - like we have for pep8 and pyflakes, and run this only if tox is available. On the CI tox will be available since we install it. On koji and brew, it will not be available, so we will not run pep8 or pyflakes (good). Line 101: Line 102: .PHONY: pep8 Line 103: pep8: Line 104: tox -- 'pep8' Line 100: tox -- 'pyflakes' Line 101: Line 102: .PHONY: pep8 Line 103: pep8: Line 104: tox -- 'pep8' > Quotes unneeded Same issue - run only if tox is available. Line 105: Line 106: .PHONY: python3 Line 107: python3: all Line 108: if [ "$(PYTHON3_SUPPORT)" == "1" ]; then \ -- To view, visit https://gerrit.ovirt.org/49952 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id583de2d411bb5bcd0f717f569d2961b555334c9 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches