Martin Polednik has posted comments on this change. Change subject: hostdev: fix scsi udev rule target ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/57373/3/vdsm/supervdsm_api/udev.py File vdsm/supervdsm_api/udev.py: PS3, Line 63: udev_path.split('/', 2)[2] > For my understanding: /dev/sgX in this case. It will never raise as we wouldn't get to this point, and if it does - yeah, exploding is fine. -- To view, visit https://gerrit.ovirt.org/57373 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98949e645b748493e3cf4a7377d17ded67e8fd66 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches