Hello Nir Soffer,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/57419
to review the following change.
Change subject: storage: Do not reference image dir in backing volume path
......................................................................
storage: Do not reference image dir in backing volume path
Until now, the backing volume path (to be written into qcow2 metadata)
was computed as ../<imgUUID>/<volUUID>. The ../<imgUUID> component
causes the backing_chain field of volumes to grow every time a live
merge is performed until it eventually overflows. The blockSD function
createImageLinks is now ensuring that all volumes of an image (including
templates) are in a directory together so we can use just the volume ID
to reference the backing volume. File domains hard link templates into
the directories of images that are dependent so this works for file
domains as well.
Change-Id: I62afa6db6f458d5c2c64ccc3427831cb76af1dcc
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1333627
Signed-off-by: Adam Litke <[email protected]>
Reviewed-on: https://gerrit.ovirt.org/57284
Reviewed-by: Nir Soffer <[email protected]>
Continuous-Integration: Jenkins CI
---
M vdsm/storage/volume.py
1 file changed, 7 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/19/57419/1
diff --git a/vdsm/storage/volume.py b/vdsm/storage/volume.py
index ef41d15..085fbf5 100644
--- a/vdsm/storage/volume.py
+++ b/vdsm/storage/volume.py
@@ -155,7 +155,13 @@
def getBackingVolumePath(imgUUID, volUUID):
- return os.path.join('..', imgUUID, volUUID)
+ # We used to return a relative path ../<imgUUID>/<volUUID> but this caused
+ # unnecessary growth in the backing chain paths with repeated live merge
+ # operations (see https://bugzilla.redhat.com/show_bug.cgi?id=1333627).
+ # Since all volumes of an image are in the same directory (including cloned
+ # templates which have a hard link on file domains and a symlink on block
+ # domains) we do not need to use the image dir reference anymore.
+ return volUUID
class VmVolumeInfo(object):
--
To view, visit https://gerrit.ovirt.org/57419
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I62afa6db6f458d5c2c64ccc3427831cb76af1dcc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Adam Litke <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
