Nir Soffer has submitted this change and it was merged.

Change subject: monitor: Convert valid to read-only property
......................................................................


monitor: Convert valid to read-only property

Status.valid was a duplicate of Status.error. This could lead to
inconsistent state if one of the attributes is not synced with the
other. Now valid is a property based on Status.error.

Change-Id: Iff27081041bbaa1e319539df67abb31f38367e7d
Signed-off-by: Nir Soffer <[email protected]>
Reviewed-on: https://gerrit.ovirt.org/39088
Reviewed-by: Liron Aravot <[email protected]>
Continuous-Integration: Jenkins CI
---
M tests/storageMonitorTests.py
M vdsm/storage/monitor.py
2 files changed, 21 insertions(+), 3 deletions(-)

Approvals:
  Nir Soffer: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests
  Liron Aravot: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/39088
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iff27081041bbaa1e319539df67abb31f38367e7d
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Ala Hino <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Freddy Rolland <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: gerrit-hooks <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to