Nir Soffer has posted comments on this change. Change subject: v2v: Do not give Xen a special treatment. ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/57430/1/lib/vdsm/v2v.py File lib/vdsm/v2v.py: Line 995: except libvirt.libvirtError as e: Line 996: if e.get_error_code() != libvirt.VIR_ERR_NO_SUPPORT: Line 997: logging.exception('Error checking for existing snapshots.') Line 998: # else: The snapshot related API is not implemented in all libvirt Line 999: # drivers. It is missing e.g. in Xen. Look good if we don't care about the driver, and can work with any driver by ignoring the unimplemented method. Line 1000: else: Line 1001: params['has_snapshots'] = ret > 0 Line 1002: Line 1003: -- To view, visit https://gerrit.ovirt.org/57430 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I597118940d42ee953d9cdc83bb44afd13b5e882a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Golembiovsky <tgole...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
