Dan Kenigsberg has posted comments on this change. Change subject: net: Expose existing ip address info through the api ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/57309/2/lib/vdsm/network/api.py File lib/vdsm/network/api.py: Line 105: Line 106: ipwrapper.linkSet(net_name, ['up']) Line 107: Line 108: Line 109: def ip_addrs_info(device): unlike the other public functions here, this one is not expected to be exposed over the VDSM api. However, please add a docstring for it Line 110: return ipaddress.addrs_info(device) Line 111: Line 112: Line 113: def _build_setup_hook_dict(req_networks, req_bondings, req_options): -- To view, visit https://gerrit.ovirt.org/57309 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I714d2f7012ddc495d580b65857ae80db5dee7a79 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
