Yaniv Bronhaim has posted comments on this change. Change subject: tests: changed Makefile so that both python2 and pyhton3 will be default. That way, all tests (including new ones) will have to support python3 eventually. ......................................................................
Patch Set 4: Code-Review-1 (3 comments) https://gerrit.ovirt.org/#/c/57106/4//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2016-05-05 17:21:48 +0300 Line 4: Commit: Irit Goihman <igoih...@redhat.com> Line 5: CommitDate: 2016-05-15 18:38:39 +0300 Line 6: Line 7: tests: changed Makefile so that both python2 and pyhton3 will try not to pass 80 characters in title Line 8: be default. Line 9: That way, all tests (including new ones) will have to support python3 eventually. Line 10: Line 11: Change-Id: Ie0f96626607fc5042eb47be0f91ecafee7965043 Line 5: CommitDate: 2016-05-15 18:38:39 +0300 Line 6: Line 7: tests: changed Makefile so that both python2 and pyhton3 will Line 8: be default. Line 9: That way, all tests (including new ones) will have to support python3 eventually. and new line after 80characters in the commit itself Line 10: Line 11: Change-Id: Ie0f96626607fc5042eb47be0f91ecafee7965043 https://gerrit.ovirt.org/#/c/57106/4/tests/Makefile.am File tests/Makefile.am: Line 76 Line 77 Line 78 Line 79 Line 80 how is this related? -- To view, visit https://gerrit.ovirt.org/57106 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie0f96626607fc5042eb47be0f91ecafee7965043 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches