Nir Soffer has uploaded a new change for review.
Change subject: tests: Separate broken test from good tests
......................................................................
tests: Separate broken test from good tests
In commit 29fa0abb687d (storagetests: add a test for
normalize_local_path) we added a new failing test for path ending with
slash. To keep the build successful, the test was marked as @brokentest.
However, since this test uses permuations, all the tests were marked
broken, instead of only the new test.
Separate the failing tests from the other, so the good tests will fail
the build when they fail.
Change-Id: I5963fcd0fb25fba6305045de80346fb0cfa3666b
Signed-off-by: Nir Soffer <nsof...@redhat.com>
---
M tests/storageServerTests.py
1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/81/57481/1
diff --git a/tests/storageServerTests.py b/tests/storageServerTests.py
index 9f2a753..7e0decd 100644
--- a/tests/storageServerTests.py
+++ b/tests/storageServerTests.py
@@ -75,7 +75,6 @@
self.assertEquals(mount_con._mount.fs_spec, "dummy-spec")
self.assertEquals(mount_con._mount.fs_file, "/tmp/dummy-spec")
- @brokentest
@permutations([
# spec, localpath
("server:/a/", "/tmp/server:_a"),
@@ -83,12 +82,16 @@
("server:/a/b", "/tmp/server:_a_b"),
("server:/a//b", "/tmp/server:_a_b"),
("server:/a/b_c", "/tmp/server:_a_b__c"),
- ("server:/", "/tmp/server:_"),
])
def test_normalize_local_path(self, spec, localpath):
con = MountConnection(spec, mountClass=FakeMount)
self.assertEqual(con._mount.fs_file, localpath)
+ @brokentest("os.path.normpath used for mount spec")
+ def test_normalize_slash(self, spec, localpath):
+ con = MountConnection("server:/", mountClass=FakeMount)
+ self.assertEqual(con._mount.fs_file, "/tmp/server:_")
+
@expandPermutations
class TestMountConnectionEquality(VdsmTestCase):
--
To view, visit https://gerrit.ovirt.org/57481
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5963fcd0fb25fba6305045de80346fb0cfa3666b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsof...@redhat.com>
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
